Make --verbosity case insensitive#2300
Merged
nohwnd merged 1 commit intomicrosoft:masterfrom Jan 20, 2020
Merged
Conversation
Contributor
|
This #2179 (comment) surprises me |
singhsarab
reviewed
Jan 13, 2020
|
|
||
| string vsTestVerbosity = "minimal"; | ||
| if (normalTestLogging.Contains(this.VSTestVerbosity)) | ||
| if (normalTestLogging.Contains(this.VSTestVerbosity.ToLowerInvariant())) |
Contributor
There was a problem hiding this comment.
Were only these 2 affected ?
Member
Author
There was a problem hiding this comment.
Yes, that were the only two case sensitive checks I could find in that file and falsify with tests. There is also
but that is unrelated to the issue, and it did not look like it would easily break. We can start another issue if you think this is an improvement that should be made.
Member
Author
Same here, it did not work for me, and the tests show that it does not work even on windows. I could see that passing |
singhsarab
approved these changes
Jan 20, 2020
Contributor
singhsarab
left a comment
singhsarab
left a comment
There was a problem hiding this comment.
@AbhitejJohn Should approve too.
AbhitejJohn
approved these changes
Jan 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Makes
--verbositycase insensitive.Related issue
Fixes #2179